CSPL-4324 Emitting events for passwords, secrets, app fw, CM, scaling and smart store #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Pull Request Test Coverage Report for Build 21753278296Details
💛 - Coveralls |
Collaborator
Pull Request Test Coverage Report for Build 21858224621Details
💛 - Coveralls |
Contributor
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 2 out of 3 committers have signed the CLA. |
kasiakoziol
commented
Feb 11, 2026
| if event.eventType != corev1.EventTypeWarning { | ||
| t.Errorf("Expected Warning event type for UpgradeBlockedVersionMismatch, got %s", event.eventType) | ||
| } | ||
| if !strings.Contains(event.message, "ClusterManager") { |
Collaborator
Author
There was a problem hiding this comment.
Why don't we check the whole message?
kasiakoziol
commented
Feb 11, 2026
| if event.eventType != corev1.EventTypeWarning { | ||
| t.Errorf("Expected Warning event type for SecretMissing, got %s", event.eventType) | ||
| } | ||
| if !strings.Contains(event.message, "nonexistent-secret") { |
kasiakoziol
commented
Feb 11, 2026
| if event.eventType != corev1.EventTypeWarning { | ||
| t.Errorf("Expected Warning event type for SecretInvalid, got %s", event.eventType) | ||
| } | ||
| if !strings.Contains(event.message, "test-secret") { |
kasiakoziol
commented
Feb 11, 2026
| if event.eventType != corev1.EventTypeWarning { | ||
| t.Errorf("Expected Warning event type for SecretInvalid, got %s", event.eventType) | ||
| } | ||
| if !strings.Contains(event.message, "test-secret-sk") { |
kasiakoziol
commented
Feb 11, 2026
| if !strings.Contains(event.message, "test-secret-sk") { | ||
| t.Errorf("Expected event message to contain secret name 'test-secret-sk', got: %s", event.message) | ||
| } | ||
| if !strings.Contains(event.message, "s3SecretKey") { |
kasiakoziol
commented
Feb 11, 2026
| if event.eventType != corev1.EventTypeWarning { | ||
| t.Errorf("Expected Warning event type for AppRepositoryConnectionFailed, got %s", event.eventType) | ||
| } | ||
| if !strings.Contains(event.message, "test-vol") { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It emits events for passwords, secrets, app fw, CM, scaling and smart store
Key Changes
Events:
Testing and Verification
Related Issues
Epic: https://splunk.atlassian.net/browse/CSPL-4324
PR Checklist